Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove submodule and apply soldeer #53

Merged
merged 4 commits into from
Jul 1, 2024
Merged

chore: remove submodule and apply soldeer #53

merged 4 commits into from
Jul 1, 2024

Conversation

huyhuynh3103
Copy link
Collaborator

Description

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@huyhuynh3103 huyhuynh3103 requested a review from TuDo1403 July 1, 2024 06:17
@huyhuynh3103
Copy link
Collaborator Author

Closed since remappings is not recommended in this repo. It can cause build errors by overriding dependency versions in parent repository

@huyhuynh3103 huyhuynh3103 deleted the feature/remove-forge-and-apply-soldeer branch July 1, 2024 06:39
@huyhuynh3103 huyhuynh3103 restored the feature/remove-forge-and-apply-soldeer branch July 1, 2024 06:50
@huyhuynh3103 huyhuynh3103 reopened this Jul 1, 2024
TuDo1403
TuDo1403 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@TuDo1403 TuDo1403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@TuDo1403 TuDo1403 merged commit 0bdd320 into mainnet Jul 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuDo1403 TuDo1403 TuDo1403 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huyhuynh3103 @TuDo1403